feat: auto-discover wings from root directory on startup by matrix9neonebuchadnezzar2199-sketch · Pull Request #219 · MemPalace/mempalace

matrix9neonebuchadnezzar2199-sketch · 2026-04-08T06:22:47Z

Summary

When users run mempalace init <dir>, the specified directory is now saved as root_dir in the config. On each MCP server startup (and on mempalace_status calls), subdirectories under root_dir are automatically scanned and registered as wings.

This eliminates the need to manually run mempalace mine <dir> --wing <name> every time a new project folder is created.

Problem

Currently, adding a new wing requires the user to manually run a mine command with --wing for each subdirectory. For users who organize multiple projects under a single parent directory, this is tedious and easy to forget. New projects silently remain invisible to MemPalace until the user remembers to register them.

Solution

Three files modified:

`config.py`

Added root_dir property — reads from config file or MEMPALACE_ROOT_DIR env var
Added _save() method — persists config changes to disk
Modified init() — accepts optional root_dir parameter and saves it

`mcp_server.py`

Added _sync_wings_from_root() — scans root_dir subdirectories, compares against known wings in both ChromaDB metadata and wing_config.json, registers any new folders as wings
Added _folder_to_wing() — normalizes folder names to valid wing names
Added IGNORE_DIRS — skips common non-project directories (node_modules, .git, pycache, etc.)
Called on server startup in main() and on each tool_status() call

`cli.py`

Modified cmd_init() — resolves the directory to an absolute path and passes it to config.init(root_dir=...)
Added TypeError fallback for detect_rooms_local() which does not accept yes kwarg in current release

Behavior

mempalace init ~/projects saves ~/projects as root_dir
On MCP server startup, subdirectories are scanned and new ones become wings automatically
Already-registered wings are skipped (no duplicates)
Deleted folders are ignored — their memories are preserved
Dotfiles and common non-project dirs (node_modules, .git, etc.) are excluded
No existing behavior is changed if root_dir is not set

Testing

Manually verified:

root_dir is correctly saved to ~/.mempalace/config.json
Subdirectories are detected as new wings on first scan
Second scan returns empty (no duplicate registration)
Creating a new folder and re-scanning detects it immediately
IGNORE_DIRS folders are correctly skipped

99/101 tests pass. The 2 failures (test_convo_mining, test_project_mining) are a pre-existing Windows-specific issue — ChromaDB holds file locks on temp directories during shutil.rmtree cleanup. Unrelated to this change.

Automated tests for the new functionality would be a good follow-up — happy to add them if the approach looks good.

Full metadata scan on every status call. _sync_wings_from_root() runs on each tool_status() and loads up to 10,000 metadata records from ChromaDB to check existing wing names. This is the same pattern flagged in Bugs and improvements #159 point 4. A status call should be fast, scanning the filesystem and loading all metadata each time is expensive. Could cache known wings or only sync on startup.
Double sync on startup. _sync_wings_from_root() is called in main() before the loop and again inside tool_status(). If an agent calls status right after connect, that's 3 full scans in seconds.
TypeError fallback swallows real errors. The try: detect_rooms_local(..., yes=...) except TypeError: detect_rooms_local(...) pattern catches any TypeError inside detect_rooms_local, not just a missing kwarg. A real bug inside that function would be silently swallowed and the function would re-run without the flag.
Accesses config internals. _sync_wings_from_root() uses _config._config_dir directly to write wing_config.json. This couples the MCP server to private config internals, should be a method on MempalaceConfig.
Wing name collisions. _folder_to_wing("My-Project") and _folder_to_wing("my_project") both produce wing_my_project. Different folders could silently map to the same wing.
No tests for a feature that runs on every startup and status call. The PR acknowledges this, but given the metadata scan cost and the new config file, automated tests would catch regressions early.

matrix9neonebuchadnezzar2199-sketch · 2026-04-09T04:53:59Z

Thanks for the thorough review @adv3nt3 — all great catches. Pushed a fix:

Full metadata scan — _sync_wings_from_root() now caches its result in a module-level variable. Subsequent calls are free unless force=True.
Double sync — Removed the call from tool_status(). Now only fires once in main().
TypeError fallback — Replaced broad except TypeError with inspect.signature() check so real bugs aren't swallowed.
Private config access — Added public methods config_dir, load_wing_config(), save_wing_config() to MempalaceConfig. MCP server no longer touches _config_dir directly.
Wing name collisions — _folder_to_wing() now preserves hyphens, so My-Project → wing_my-project and my_project → wing_my_project produce different names.
Tests — Added tests/test_auto_discover.py covering _folder_to_wing, _sync_wings_from_root (cache, ignore dirs, no root_dir), and MempalaceConfig root_dir/wing_config roundtrip.

web3guru888

✨ Review of #219 — feat: auto-discover wings from root directory on startup

Scope: +298/−4 · 4 file(s) · touches core

mempalace/cli.py (modified: +12/−2)
mempalace/config.py (modified: +46/−1)
⚠️ mempalace/mcp_server.py (modified: +116/−1)
tests/test_auto_discover.py (added: +124/−0)

Technical Analysis

🔌 MCP server dispatch changes — verify JSON-RPC compliance and backward compatibility
🪟 Windows compatibility — verify path handling works cross-platform

Issues

⚠️ Touches mempalace/mcp_server.py — Core MCP server — maintainer guards this closely

Strengths

✅ Includes test coverage

🟡 Needs attention — touches guarded files and has items to address.

_{🏛️ Reviewed by MemPalace-AGI · Autonomous research system with perfect memory · Showcase: Truth Palace of Atlantis}

…leanup (MemPalace#219) - Remove col.get(metadatas) from _sync_wings_from_root; use wing_config.json only - _folder_to_wing now preserves CJK/Unicode characters via \w regex - Add fallback for empty slug after sanitization - tool_status calls cached _sync_wings_from_root(force=False) - Remove stray blank lines - 4 new tests (CJK, Korean, empty fallback, no-ChromaDB dependency) Made-with: Cursor

matrix9neonebuchadnezzar2199-sketch · 2026-04-11T10:40:02Z

@web3guru888 Thank you for the review. Addressed all three items in the latest commit:

MCP server impact (−ChromaDB full scan) Removed col.get(include=["metadatas"], limit=10000) from _sync_wings_from_root(). Wing registration now uses wing_config.json as the single source of truth — no ChromaDB read at all during discovery. This eliminates the same performance risk identified in mempalace_list_wings / mempalace_list_rooms / mempalace_get_taxonomy silently return empty results on large collections #338 and reduces the mcp_server.py footprint of this feature.
Windows / cross-platform compatibility folder_to_wing() now uses re.sub(r'[^\w\-]+', '', slug) which is Unicode-aware in Python's re module. CJK folder names (日本語, 한국어, etc.) are preserved instead of being stripped to underscores. Added tests for CJK and Korean folder names, plus an empty-slug fallback to "unnamed".
JSON-RPC compliance tool_status() now calls _sync_wings_from_root(force=False) which returns the startup cache immediately (no I/O, no rescan). The JSON-RPC request/response format is untouched.

Tests: 16 passed (test_auto_discover.py), 131 total passed. 2 pre-existing Windows ChromaDB file-lock failures unrelated.

…leanup (MemPalace#219) - Remove col.get(metadatas) from _sync_wings_from_root; use wing_config.json only - _folder_to_wing now preserves CJK/Unicode characters via \w regex - Add fallback for empty slug after sanitization - tool_status calls cached _sync_wings_from_root(force=False) - Remove stray blank lines - 4 new tests (CJK, Korean, empty fallback, no-ChromaDB dependency) Made-with: Cursor

Use strip('_-') so '--project--' normalizes to wing_project; inner hyphens unchanged. Made-with: Cursor

…spect Made-with: Cursor

matrix9neonebuchadnezzar2199-sketch · 2026-04-14T11:30:57Z

@web3guru888 Thank you for the review. Addressed all three items and rebased onto current develop (post-#852 ChromaBackend refactor).

MCP server impact — minimized Removed col.get(include=["metadatas"]) entirely from _sync_wings_from_root(). Wing discovery now uses wing_config.json as the single source of truth — zero ChromaDB reads during discovery. Compatible with the new ChromaBackend abstraction layer from refactor: route all chromadb access through ChromaBackend (v4 prep) #852.
Windows / cross-platform folder_to_wing() now uses re.sub(r'[^\w\-]+', '', slug) (Unicode-aware \w). CJK folder names are preserved. Empty slugs fall back to "unnamed". strip('_-') cleans leading/trailing noise.
JSON-RPC compliance tool_status() calls _sync_wings_from_root(force=False) — returns startup cache immediately, no I/O. JSON-RPC format untouched.

Tests: 16 passed (test_auto_discover.py), 879 passed total. Rebased cleanly onto develop at b060171 (#852 merge).

Made-with: Cursor

matrix9neonebuchadnezzar2199-sketch · 2026-04-14T12:10:03Z

@web3guru888 Thank you for the review. Addressed all three items, rebased onto current develop (post-#852 ChromaBackend refactor), and CI is now fully green.

MCP server impact — minimized Removed col.get(include=["metadatas"]) entirely from _sync_wings_from_root(). Wing discovery now uses wing_config.json as the single source of truth — zero ChromaDB reads during discovery. Compatible with the new ChromaBackend abstraction layer from refactor: route all chromadb access through ChromaBackend (v4 prep) #852.
Windows / cross-platform folder_to_wing() now uses re.sub(r'[^\w\-]+', '', slug) (Unicode-aware \w). CJK folder names are preserved. Empty slugs fall back to "unnamed". strip('_-') cleans leading/trailing noise.
JSON-RPC compliance tool_status() calls _sync_wings_from_root(force=False) — returns startup cache immediately, no I/O on every call. JSON-RPC format untouched.

Tests: 16 passed (test_auto_discover.py), full suite green. CI: 6/6 checks passed.

Made-with: Cursor

web3guru888 reviewed Apr 11, 2026

View reviewed changes

matrix9neonebuchadnezzar2199-sketch requested review from bensig and milla-jovovich as code owners April 11, 2026 10:34

bensig changed the base branch from main to develop April 11, 2026 22:23

bensig requested a review from igorls as a code owner April 11, 2026 22:23

igorls added area/cli CLI commands area/mcp MCP server and tools enhancement New feature or request labels Apr 14, 2026

matrix9neonebuchadnezzar2199-sketch and others added 5 commits April 14, 2026 20:23

feat: auto-discover wings from root directory on startup

2ae9be0

fix: address review — cache scans, fix collisions, add tests

1dead19

fix(auto-discover): strip leading/trailing hyphens in _folder_to_wing

ca987b0

Use strip('_-') so '--project--' normalizes to wing_project; inner hyphens unchanged. Made-with: Cursor

fix(cli): use TypeError fallback for detect_rooms_local instead of in…

59e940b

…spect Made-with: Cursor

matrix9neonebuchadnezzar2199-sketch force-pushed the feat/auto-discover-wings-from-root-dir branch from 9e0d0d4 to 59e940b Compare April 14, 2026 11:25

matrix9neonebuchadnezzar2199-sketch added 2 commits April 14, 2026 20:57

fix: dedupe wing config helpers on MempalaceConfig; ruff format for CI

f301e8a

Made-with: Cursor

style: ruff format remaining test files

1bd2888

Made-with: Cursor

merge: resolve mcp_server.py conflict with upstream develop

2a7aeca

Made-with: Cursor

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: auto-discover wings from root directory on startup#219

feat: auto-discover wings from root directory on startup#219
matrix9neonebuchadnezzar2199-sketch wants to merge 8 commits intoMemPalace:developfrom
matrix9neonebuchadnezzar2199-sketch:feat/auto-discover-wings-from-root-dir

matrix9neonebuchadnezzar2199-sketch commented Apr 8, 2026

Uh oh!

adv3nt3 commented Apr 8, 2026

Uh oh!

matrix9neonebuchadnezzar2199-sketch commented Apr 9, 2026

Uh oh!

web3guru888 left a comment

Uh oh!

matrix9neonebuchadnezzar2199-sketch commented Apr 11, 2026

Uh oh!

matrix9neonebuchadnezzar2199-sketch commented Apr 14, 2026

Uh oh!

matrix9neonebuchadnezzar2199-sketch commented Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

matrix9neonebuchadnezzar2199-sketch commented Apr 8, 2026

Summary

Problem

Solution

config.py

mcp_server.py

cli.py

Behavior

Testing

Related

Uh oh!

adv3nt3 commented Apr 8, 2026

Uh oh!

matrix9neonebuchadnezzar2199-sketch commented Apr 9, 2026

Uh oh!

web3guru888 left a comment

Choose a reason for hiding this comment

Technical Analysis

Issues

Strengths

Uh oh!

matrix9neonebuchadnezzar2199-sketch commented Apr 11, 2026

Uh oh!

matrix9neonebuchadnezzar2199-sketch commented Apr 14, 2026

Uh oh!

matrix9neonebuchadnezzar2199-sketch commented Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

`config.py`

`mcp_server.py`

`cli.py`